netdev - Re: [patch -next] fsl/fman: use the ALIGN() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160106.152738.341986591893293965.davem@davemloft.net>
Date:	Wed, 06 Jan 2016 15:27:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	igal.liberman@...escale.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch -next] fsl/fman: use the ALIGN() macro

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 6 Jan 2016 13:03:08 +0300

> diff --git a/drivers/net/ethernet/freescale/fman/fman_sp.c b/drivers/net/ethernet/freescale/fman/fman_sp.c
> index f9e7aa3..b527da1 100644
> --- a/drivers/net/ethernet/freescale/fman/fman_sp.c
> +++ b/drivers/net/ethernet/freescale/fman/fman_sp.c
> @@ -92,11 +92,8 @@ int fman_sp_build_buffer_struct(struct fman_sp_int_context_data_copy *
>  	u32 tmp;
>  
>  	/* Align start of internal context data to 16 byte */
> -	int_context_data_copy->ext_buf_offset = (u16)
> -		((buffer_prefix_content->priv_data_size & (OFFSET_UNITS - 1)) ?
> -		((buffer_prefix_content->priv_data_size + OFFSET_UNITS) &
> -			~(u16)(OFFSET_UNITS - 1)) :
> -		buffer_prefix_content->priv_data_size);
> +	int_context_data_copy->ext_buf_offset =
> +		(u16)ALIGN(buffer_prefix_content->priv_data_size, 16);

Why are you using '16' instead of OFFSET_UNITS?

Unless you can come up with a good reason, please use OFFSET_UNITS instead
of a magic constant.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html