netdev - Re: [PATCH net-next 01/12] net/mlx5_core: Introduce flow steering autogrouped flow table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 05 Jan 2016 23:58:25 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	saeedm@...lanox.com
Cc:	netdev@...r.kernel.org, dledford@...hat.com, ogerlitz@...lanox.com,
	eranbe@...lanox.com, talal@...lanox.com, majd@...lanox.com,
	matanb@...lanox.com, maorg@...lanox.com, monis@...lanox.com,
	saeedm@....mellanox.co.il
Subject: Re: [PATCH net-next 01/12] net/mlx5_core: Introduce flow steering
 autogrouped flow table

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Tue,  5 Jan 2016 22:04:02 +0200

> -	/* Add node to tree */
> -	tree_init_node(&fg->node, 1, del_flow_group);

Why in the world would you take a properly formatted comment:

> +	/*Add node to tree*/

And proceed to molest it like this?

Please don't do this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html