netdev - Re: [PATCH] net: take care of bonding in build_skb_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Jan 2016 14:44:59 +0800
From:	zhuyj <zyjzyj2000@...il.com>
To:	Wengang Wang <wen.gang.wang@...cle.com>,
	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: take care of bonding in build_skb_flow_key

IMHO, the following comments will help us all.

         case NETDEV_CHANGEMTU:
                 /* TODO: Should slaves be allowed to
                  * independently alter their MTU?  For
                  * an active-backup bond, slaves need
                  * not be the same type of device, so
                  * MTUs may vary.  For other modes,
                  * slaves arguably should have the
                  * same MTUs. To do this, we'd need to
                  * take over the slave's change_mtu
                  * function for the duration of their
                  * servitude.
                  */
                 break;

Best Regards!
Zhu Yanjun

On 01/06/2016 02:32 PM, Wengang Wang wrote:
>
>
> 在 2016年01月06日 14:18, David Miller 写道:
>> From: Wengang Wang <wen.gang.wang@...cle.com>
>> Date: Wed,  6 Jan 2016 13:49:28 +0800
>>
>>> @@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4 
>>> *fl4, const struct sk_buff *skb,
>>>                      const struct sock *sk)
>>>   {
>>>       const struct iphdr *iph = ip_hdr(skb);
>>> -    int oif = skb->dev->ifindex;
>>> +    int oif;
>>> +    struct net_device *master = NULL;
>>> +
>>>       u8 tos = RT_TOS(iph->tos);
>>>       u8 prot = iph->protocol;
>>>       u32 mark = skb->mark;
>> Please fix the stlye of these variable declarations:
>>
>> 1) Order them from longest line to shortest line, also known
>>     as "reverse christmas tree" layout.
>>
>> 2) Do not add an empty line in the middle of these variable
>>     declarations.
> OK, will do in second drop.
>
> thanks,
> wengang
> -- 
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html