netdev - Re: [PATCH net-next] bpf: add skb_postpush_rcsum and fix dev_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568DC506.6020200@stressinduktion.org>
Date:	Thu, 7 Jan 2016 02:53:10 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Daniel Borkmann <daniel@...earbox.net>, davem@...emloft.net
Cc:	alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bpf: add skb_postpush_rcsum and fix
 dev_forward_skb occasions

On 07.01.2016 02:01, Daniel Borkmann wrote:
> +static inline void skb_postpush_rcsum(struct sk_buff *skb,
> +				      const void *start, unsigned int len)
> +{
> +	if (skb->ip_summed == CHECKSUM_COMPLETE)
> +		skb->csum = csum_add(skb->csum, csum_partial(start, len, 0));

skb->csum = csum_partial(start, len, skb->csum);

should work without calling carry-add twice, no?

Bye,
Hannes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html