netdev - Re: [PATCH v2 net-next 4/5] fou: enable LCO in FOU and GUE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jan 2016 10:51:35 -0800
From:	Tom Herbert <tom@...bertland.com>
To:	Edward Cree <ecree@...arflare.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH v2 net-next 4/5] fou: enable LCO in FOU and GUE

On Thu, Jan 7, 2016 at 9:13 AM, Edward Cree <ecree@...arflare.com> wrote:
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
>  net/ipv4/fou.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
> index e0fcbbb..2b0002f 100644
> --- a/net/ipv4/fou.c
> +++ b/net/ipv4/fou.c
> @@ -773,7 +773,6 @@ static void fou_build_udp(struct sk_buff *skb, struct ip_tunnel_encap *e,
>         uh->dest = e->dport;
>         uh->source = sport;
>         uh->len = htons(skb->len);
> -       uh->check = 0;
>         udp_set_csum(!(e->flags & TUNNEL_ENCAP_FLAG_CSUM), skb,
>                      fl4->saddr, fl4->daddr, skb->len);
>
> @@ -787,7 +786,7 @@ int fou_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
>         int type = csum ? SKB_GSO_UDP_TUNNEL_CSUM : SKB_GSO_UDP_TUNNEL;
>         __be16 sport;
>
> -       skb = iptunnel_handle_offloads(skb, csum, type);
> +       skb = iptunnel_handle_offloads(skb, false, type);

It might good to have another iptunnel_handle_offloads (lifke
iptunnel_handle_offloads_nocsum) function that doesn't have csum
parameter for readability.

>
>         if (IS_ERR(skb))
>                 return PTR_ERR(skb);
> @@ -821,7 +820,7 @@ int gue_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
>
>         optlen += need_priv ? GUE_LEN_PRIV : 0;
>
> -       skb = iptunnel_handle_offloads(skb, csum, type);
> +       skb = iptunnel_handle_offloads(skb, false, type);
>
>         if (IS_ERR(skb))
>                 return PTR_ERR(skb);
>
> The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error, please notify the sender immediately and delete the message. Unless you are an addressee (or authorized to receive for an addressee), you may not use, copy or disclose to anyone this message or any information contained in this message. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.