netdev - Re: [PATCH net-next v2] net, sched: add clsact qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568EF308.1060505@gmail.com>
Date:	Thu, 07 Jan 2016 15:21:44 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>, davem@...emloft.net
CC:	alexei.starovoitov@...il.com, jhs@...atatu.com,
	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net, sched: add clsact qdisc

On 16-01-07 01:29 PM, Daniel Borkmann wrote:
> This work adds a generalization of the ingress qdisc as a qdisc holding
> only classifiers. The clsact qdisc works on ingress, but also on egress.
> In both cases, it's execution happens without taking the qdisc lock, and
> the main difference for the egress part compared to prior version of [1]
> is that this can be applied with _any_ underlying real egress qdisc (also
> classless ones).
> 

[...]

> Prior work on a mqprio prequeue() facility [1] was done mainly by John Fastabend.
> 
>   [1] http://patchwork.ozlabs.org/patch/512949/
> 
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Acked-by: John Fastabend <john.r.fastabend@...el.com>

Looks good to me and is a better implementation then my initial take
with the mqprio perqueue() stuff.

I think this complements the lockless work and also putting it in front
of the qdisc bypass logic lets us skip the qdisc but also still use
this for queue selection. Further we can build interesting queue
select logic now and maybe remove select_queue() from the ndo ops
eventually? With this and xps there really is no reason to have drivers
implementing some under-the-covers logic anymore.

Thanks,
John