netdev - Re: [PATCH] net: lpc_eth: Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160108155832.GH4389@lunn.ch>
Date:	Fri, 8 Jan 2016 16:58:32 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Fabio Estevam <festevam@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH] net: lpc_eth: Remove unused variables

On Fri, Jan 08, 2016 at 10:19:16AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@....com>
> 
> Commit e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> introduced the following build warnings:
> 
> drivers/net/ethernet/nxp/lpc_eth.c: In function 'lpc_mii_init':
> drivers/net/ethernet/nxp/lpc_eth.c:865:1: warning: label 'err_out_1' defined but not used [-Wunused-label]
> drivers/net/ethernet/nxp/lpc_eth.c:826:20: warning: unused variable 'i' [-Wunused-variable]
> 
> Remove the unused variables to fix them.
> 
> Reported-by: Olof's autobuilder <build@...om.net>
> Signed-off-by: Fabio Estevam <fabio.estevam@....com>

Acked-by: Andrew Lunn <andrew@...n.ch>

	  Andrew

> ---
>  drivers/net/ethernet/nxp/lpc_eth.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
> index a9ce37f..b1ce7aa 100644
> --- a/drivers/net/ethernet/nxp/lpc_eth.c
> +++ b/drivers/net/ethernet/nxp/lpc_eth.c
> @@ -823,7 +823,7 @@ static int lpc_mii_probe(struct net_device *ndev)
>  
>  static int lpc_mii_init(struct netdata_local *pldat)
>  {
> -	int err = -ENXIO, i;
> +	int err = -ENXIO;
>  
>  	pldat->mii_bus = mdiobus_alloc();
>  	if (!pldat->mii_bus) {
> @@ -862,7 +862,6 @@ static int lpc_mii_init(struct netdata_local *pldat)
>  
>  err_out_unregister_bus:
>  	mdiobus_unregister(pldat->mii_bus);
> -err_out_1:
>  	mdiobus_free(pldat->mii_bus);
>  err_out:
>  	return err;
> -- 
> 1.9.1
>