netdev - Re: [PATCH net-next v3 8/8] geneve: break dependency to network drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5690204B.7000004@stressinduktion.org>
Date:	Fri, 8 Jan 2016 21:47:07 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Jesse Gross <jesse@...nel.org>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3 8/8] geneve: break dependency to network
 drivers

On 07.01.2016 01:18, Jesse Gross wrote:
> I think we should merge vxlan_get_rx_port() and geneve_get_rx_port()
> into a single generic function. For drivers that support both, they
> now have two calls to get notified for all offloaded ports. This
> actually can cause problems related to duplicates, similar to what you
> feared before.

Checking out the ndo_add_vxlan_port callbacks, we cannot change how we 
refresh the ports unfortunately. For some drivers it might be easy to 
update, some look a little bit more complicated.

I guess we should try to keep more complexity in the core and make sure 
we only call those functions if necessary for the particular type of 
offload than to replicate the logic in each driver.

If you agree I prepare this series with the changes to have separate 
callbacks, address your other feedback and send it out.

Thanks,
Hannes