netdev - Re: [PATCH] net: pktgen: support injecting packets for qdisc testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56903041.8090900@gmail.com>
Date:	Fri, 08 Jan 2016 13:55:13 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	netdev@...r.kernel.org, alexei.starovoitov@...il.com,
	davem@...emloft.net, jhs@...atatu.com
Subject: Re: [PATCH] net: pktgen: support injecting packets for qdisc testing

On 16-01-08 01:36 PM, Eric Dumazet wrote:
> On Fri, 2016-01-08 at 07:38 -0800, John Fastabend wrote:
> 
>> Also I'll respin this with a change so xmit_{drop|cn|policed} are not
>> counted as tx_bytes and pkts sent (idea from Jamal). However I won't
>> abort the burst because I do like this stressing the entry point of my
>> qdisc.
> 
> This reminds me that bonding/team drivers always return NETDEV_TX_OK
> status, even if the chosen slave could not queue or send the packet.
> 
> 
> 

hmm this could potentially break protocols that are handling the
return codes like fcoe which puts a packet back on its queue if it
can't be sent.

.John