netdev - Re: [PATCH net] openvswitch: compute needed headroom for internal vports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_ARw+FC69yfhq_b0GDvxyQhTLLqUwJ81nYCA5XqrTNwOA@mail.gmail.com>
Date:	Fri, 8 Jan 2016 14:53:42 -0800
From:	pravin shelar <pshelar@....org>
To:	Paolo Abeni <pabeni@...hat.com>
Cc:	netdev@...r.kernel.org, Pravin Shelar <pshelar@...ira.com>,
	"David S. Miller" <davem@...emloft.net>,
	Flavio Leitner <fbl@...close.org>
Subject: Re: [PATCH net] openvswitch: compute needed headroom for internal vports

On Fri, Jan 8, 2016 at 1:50 PM, Paolo Abeni <pabeni@...hat.com> wrote:
> Currently the ovs internal vports always use a default needed_headroom.
> This leads to a skb head copy while xmitting on ovs swith via vport
> that add some kind of encapsulation (gre, geneve, etc.).
>
> This patch add book-keeping for the maximum needed_headroom used by
> the non internal vports in any dp, updating it on vport creation and
> deletion.
>
> Said value is than used as needed_headroom for internal vports,
> avoiding the above copy.
>
Why is this done only for internal devices? In most common case of
traffic the packet enters OVS from tap or other netdev type vport
device.

> With ~1000 bytes long frames, this give about a 6% xmit performance
> improvement in case of vxlan tunnels and about 8% when using geneve
> tunnels.
>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> Acked-by: Flavio Leitner <fbl@...close.org>
> --