netdev - Re: [PATCH v2 net-next 3/5] net: vxlan: enable local checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UfqNgdRYhVRJtT24oBKK4SBqy+QOtWQdD4H09zo2sj32A@mail.gmail.com>
Date:	Thu, 7 Jan 2016 19:46:05 -0800
From:	Alexander Duyck <alexander.duyck@...il.com>
To:	Edward Cree <ecree@...arflare.com>
Cc:	David Miller <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	linux-net-drivers@...arflare.com, Tom Herbert <tom@...bertland.com>
Subject: Re: [PATCH v2 net-next 3/5] net: vxlan: enable local checksum offload

On Thu, Jan 7, 2016 at 9:12 AM, Edward Cree <ecree@...arflare.com> wrote:
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
>  drivers/net/vxlan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 6369a57..d4acbc9 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1733,7 +1733,7 @@ static int vxlan6_xmit_skb(struct dst_entry *dst, struct sock *sk,
>                 goto err;
>         }
>
> -       skb = iptunnel_handle_offloads(skb, udp_sum, type);
> +       skb = iptunnel_handle_offloads(skb, false, type);
>         if (IS_ERR(skb)) {
>                 err = -EINVAL;
>                 goto err;
> @@ -1814,7 +1814,7 @@ static int vxlan_xmit_skb(struct rtable *rt, struct sock *sk, struct sk_buff *sk
>         if (WARN_ON(!skb))
>                 return -ENOMEM;
>
> -       skb = iptunnel_handle_offloads(skb, udp_sum, type);
> +       skb = iptunnel_handle_offloads(skb, false, type);
>         if (IS_ERR(skb))
>                 return PTR_ERR(skb);
>
>

So I just tried testing your patches and as it turns out you are still
missing some bits.  In this patch for instance the calls to
udp_tunnel_xmit_skb and udp_tunnel6_xmit skb need to be updated so
that you pass false for the last parameter and allow the use of your
udp_set_csum modifications.

- Alex