lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 9 Jan 2016 02:36:55 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Joshua Henderson <joshua.henderson@...rochip.com>
Cc:	linux-kernel@...r.kernel.org,
	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] net: phy: Add support for SMSC LAN8740 PHY

On Fri, Jan 08, 2016 at 05:57:20PM -0700, Joshua Henderson wrote:
> LAN8740 has a different phy_id than LAN8710/LAN8720.
> 
> Signed-off-by: Joshua Henderson <joshua.henderson@...rochip.com>
> ---
>  drivers/net/phy/smsc.c |   24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
> index dc2da87..34021a5 100644
> --- a/drivers/net/phy/smsc.c
> +++ b/drivers/net/phy/smsc.c
> @@ -264,6 +264,29 @@ static struct phy_driver smsc_phy_driver[] = {
>  	.resume		= genphy_resume,
>  
>  	.driver		= { .owner = THIS_MODULE, }
> +}, {
> +	.phy_id		= 0x0007c110,
> +	.phy_id_mask	= 0xfffffff0,
> +	.name		= "SMSC LAN8740",
> +
> +	.features	= (PHY_BASIC_FEATURES | SUPPORTED_Pause
> +				| SUPPORTED_Asym_Pause),
> +	.flags		= PHY_HAS_INTERRUPT | PHY_HAS_MAGICANEG,
> +
> +	/* basic functions */
> +	.config_aneg	= genphy_config_aneg,
> +	.read_status	= lan87xx_read_status,
> +	.config_init	= smsc_phy_config_init,
> +	.soft_reset	= smsc_phy_reset,
> +
> +	/* IRQ related */
> +	.ack_interrupt	= smsc_phy_ack_interrupt,
> +	.config_intr	= smsc_phy_config_intr,
> +
> +	.suspend	= genphy_suspend,
> +	.resume		= genphy_resume,
> +
> +	.driver		= { .owner = THIS_MODULE, }
>  } };

Hi Joshua

You should remove this .driver line. The core sets it now.

    Andrew

Powered by blists - more mailing lists