netdev - Re: [PATCHv2 net-next 1/3] cxgb4: Add LRO infrastructure for cxgb4i driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160108.215325.556490793545398776.davem@davemloft.net>
Date:	Fri, 08 Jan 2016 21:53:25 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hariprasad@...lsio.com
Cc:	netdev@...r.kernel.org, linux-scsi@...r.kernel.org,
	JBottomley@...n.com, martin.petersen@...cle.com,
	leedom@...lsio.com, kxie@...lsio.com, manojmalviya@...lsio.com,
	nirranjan@...lsio.com
Subject: Re: [PATCHv2 net-next 1/3] cxgb4: Add LRO infrastructure for
 cxgb4i driver

From: Hariprasad Shenai <hariprasad@...lsio.com>
Date: Thu,  7 Jan 2016 14:54:05 +0530

> +	struct sk_buff *skb_head, *skb_tail; /* list of aggregated sessions */

Don't invent your own list scheme, use struct sk_buff_head and
the appropriate initializers and helpers.

If people do their own list handling, then it's extremely difficult
to change the skb queue implementation.