netdev - Re: [PATCH net-next v4 05/10] fm10k: add rtnl lock protection in fm10k_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56918D42.8030401@stressinduktion.org>
Date:	Sat, 9 Jan 2016 23:44:18 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Florian Westphal <fw@...len.de>
Cc:	netdev@...r.kernel.org, jesse@...nel.org,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: [PATCH net-next v4 05/10] fm10k: add rtnl lock protection in
 fm10k_io_resume

On 09.01.2016 22:51, Florian Westphal wrote:
> Hannes Frederic Sowa <hannes@...essinduktion.org> wrote:
>> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
>> index 4eb7a6fa6b0ddc..846d9b731c8c14 100644
>> --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
>> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
>> @@ -2350,8 +2350,10 @@ static void fm10k_io_resume(struct pci_dev *pdev)
>>   	/* reset clock */
>>   	fm10k_ts_reset(interface);
>>
>> +	rtnl_lock();
>>   	if (netif_running(netdev))
>>   		err = fm10k_open(netdev);
>> +	rtnl_lock();
>
> Hmm.  Looks like copy&paste error :)

Oh, yeah. Thanks, Florian, fixed it up locally.