netdev - Re: [PATCH net] vxlan: fix test which detect duplicate vxlan iface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160109.210509.939212619090970717.davem@davemloft.net>
Date:	Sat, 09 Jan 2016 21:05:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] vxlan: fix test which detect duplicate vxlan iface

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Thu,  7 Jan 2016 11:26:53 +0100

> When a vxlan interface is created, the driver checks that there is not
> another vxlan interface with the same properties. To do this, it checks
> the existing vxlan udp socket. Since commit 1c51a9159dde, the creation of
> the vxlan socket is done only when the interface is set up, thus it breaks
> that test.
> 
> Example:
> $ ip l a vxlan10 type vxlan id 10 group 239.0.0.10 dev eth0 dstport 0
> $ ip l a vxlan11 type vxlan id 10 group 239.0.0.10 dev eth0 dstport 0
> $ ip -br l | grep vxlan
> vxlan10          DOWN           f2:55:1c:6a:fb:00 <BROADCAST,MULTICAST>
> vxlan11          DOWN           7a:cb:b9:38:59:0d <BROADCAST,MULTICAST>
> 
> Instead of checking sockets, let's loop over the vxlan iface list.
> 
> Fixes: 1c51a9159dde ("vxlan: fix race caused by dropping rtnl_unlock")
> Reported-by: Thomas Faivre <thomas.faivre@...nd.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied and queued up for -stable, thanks.