netdev - Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160110172109.GF22229@lunn.ch>
Date:	Sun, 10 Jan 2016 18:21:09 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe
 function

> drivers/net/ethernet/amd/au1000_eth.c:  /* WARNING: bus->phy_map[phy_addr].attached_dev == dev does
> 	[ no idea what to do with that comment ]

That comment is very generic, it applies to all MDIO devices. So i'm
tempted to remove it. I will send a patch, probably tomorrow.

> drivers/net/ethernet/broadcom/sb1250-mac.c:             phy_dev = sc->mii_bus->phy_map[i];
> 	[ can use phy_find_first ]

Yes, phy_find_first.

> drivers/staging/netlogic/xlr_net.c:     struct phy_device *phydev = priv->mii_bus->phy_map[priv->phy_addr];
> 	[ several ]	

Odd that i missed that file for phy_map, but did patch it for
phydev_name().

I will send a patch for that, but probably tomorrow.

  Andrew