netdev - Re: [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878u3wi8uo.fsf@kamboji.qca.qualcomm.com>
Date:	Mon, 11 Jan 2016 14:44:31 +0200
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
Cc:	Jia-Ju Bai <baijiaju1990@....com>, johannes.berg@...el.com,
	emmanuel.grumbach@...el.com, ilw@...ux.intel.com,
	linuxwifi@...el.com, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up

Stanislaw Gruszka <sgruszka@...hat.com> writes:

> On Sun, Jan 10, 2016 at 10:19:23AM +0800, Jia-Ju Bai wrote:
>> diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c
>> index 6656215..fd7b5c7 100644
>> --- a/drivers/net/wireless/iwlegacy/4965-mac.c
>> +++ b/drivers/net/wireless/iwlegacy/4965-mac.c
>> @@ -5577,6 +5577,7 @@ __il4965_up(struct il_priv *il)
>>  	ret = il4965_hw_nic_init(il);
>>  	if (ret) {
>>  		IL_ERR("Unable to init nic\n");
>> +		il_dealloc_bcast_stations(il);
>>  		return ret;
>>  	}
>
> Please do not repost patches so frequent and if you repost
> the unchanged patch mark it so i.e. [PATCH repost].

"repost" just confuses me and creates more work for me. Better to ping
on the original patch and even better is to check patchwork which shows
up-to-date status of wireless patches:

https://patchwork.kernel.org/project/linux-wireless/list/

-- 
Kalle Valo