netdev - Re: [PATCH v2 0/3] can: sja1000: support for technologic version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160111165807.GA7116@localhost>
Date:	Mon, 11 Jan 2016 11:58:08 -0500
From:	Damien Riegel <damien.riegel@...oirfairelinux.com>
To:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-can@...r.kernel.org
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Wolfgang Grandegger <wg@...ndegger.com>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	kernel@...oirfairelinux.com
Subject: Re: [PATCH v2 0/3] can: sja1000: support for technologic version

Hi Marc,

On Thu, Dec 24, 2015 at 12:42:50PM -0500, Damien Riegel wrote:
> This patchset introduces support for the technologic version of the
> SJA1000. Access to IP's registers are proxied through a window,
> requiring two bus accesses to read or write a register. These accesses
> must be protected by a spinlock to prevent race conditions. Currently,
> there is no easy way to allocate and initialize this spinlock.
> 
> SJA1000 already provides a way to allocate private data, but
> sja1000_platform.c makes no use of it.
> 
> Patch 1 adds the capability to allocate and initialize private data on a
> per-compatible basis in sja1000_platform.c.
> 
> Patch 2 updates device tree documentation to add the technologic
> version.
> 
> Patch 3 updates the driver to implement the technologic version
> 

Did you have a chance to take a look at this patchset? I would
appreciate your feedback, especially on the first patch.


Thanks,
Damien