netdev - Re: [PATCH net-next] net: Fix typo in netdev_intersect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jan 2016 21:24:41 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Tom Herbert <tom@...bertland.com>, davem@...emloft.net,
	netdev@...r.kernel.org
Cc:	jackm@....mellanox.co.il, kernel-team@...com
Subject: Re: [PATCH net-next] net: Fix typo in netdev_intersect_features

Hello.

On 01/11/2016 09:19 PM, Tom Herbert wrote:

> Obviously need to 'or in NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM.
>
> Fixes: c8cd0989bd151f ("net: Eliminate NETIF_F_GEN_CSUM and NETIF_F_V[46]_CSUM")
> Reported-by: Jack Morgenstein <jackm@....mellanox.co.il>
> Signed-off-by: Tom Herbert <tom@...bertland.com>
> ---
>   include/linux/netdevice.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 8d8e5ca..a951274 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -3871,9 +3871,9 @@ static inline netdev_features_t netdev_intersect_features(netdev_features_t f1,
>   {
>   	if ((f1 ^ f2) & NETIF_F_HW_CSUM) {
>   		if (f1 & NETIF_F_HW_CSUM)
> -			f1 |= (NETIF_F_IP_CSUM|NETIF_F_IP_CSUM);
> +			f1 |= (NETIF_F_IP_CSUM|NETIF_F_IPV6_CSUM);
>   		else
> -			f2 |= (NETIF_F_IP_CSUM|NETIF_F_IP_CSUM);
> +			f2 |= (NETIF_F_IP_CSUM|NETIF_F_IPV6_CSUM);

    The general kernel coding style is to have the operators surrounded by spaces.

[...]

WBR, Sergei