netdev - Re: [PATCH 5/5] net: can: ifi: Add IFI CANFD IP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jan 2016 20:33:11 +0100
From:	Marek Vasut <marex@...x.de>
To:	kbuild test robot <lkp@...el.com>
Cc:	kbuild-all@...org, netdev@...r.kernel.org,
	"Marc Kleine-Budde" <mkl@...gutronix.de>,
	Oliver Hartkopp <socketcan@...tkopp.net>,
	Mark Rutland <mark.rutland@....com>,
	Wolfgang Grandegger <wg@...ndegger.com>
Subject: Re: [PATCH 5/5] net: can: ifi: Add IFI CANFD IP support

On Monday, January 11, 2016 at 08:29:28 PM, kbuild test robot wrote:
> Hi Marek,

Hi Robot,

> [auto build test WARNING on net/master]
> [also build test WARNING on v4.4 next-20160111]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the system]
> 
> url:   
> https://github.com/0day-ci/linux/commits/Marek-Vasut/net-can-Sort-the-Kcon
> fig-includes/20160112-025020 config: x86_64-allmodconfig (attached as
> .config)
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/net/can/ifi_canfd/ifi_canfd.c: In function 'ifi_canfd_isr':
> >> drivers/net/can/ifi_canfd/ifi_canfd.c:486:27: warning: large integer
> >> implicitly truncated to unsigned type [-Woverflow]
> 
>      const u32 clr_irq_mask = ~(IFI_CANFD_INTERRUPT_SET_IRQ |
>                               ^
>    drivers/net/can/ifi_canfd/ifi_canfd.c: In function 'ifi_canfd_start':
>    drivers/net/can/ifi_canfd/ifi_canfd.c:640:9: warning: large integer
> implicitly truncated to unsigned type [-Woverflow]
> writel(~IFI_CANFD_INTERRUPT_SET_IRQ, priv->base + IFI_CANFD_INTERRUPT); ^
>    drivers/net/can/ifi_canfd/ifi_canfd.c: In function 'ifi_canfd_stop':
>    drivers/net/can/ifi_canfd/ifi_canfd.c:675:9: warning: large integer
> implicitly truncated to unsigned type [-Woverflow]
> writel(~IFI_CANFD_INTERRUPT_SET_IRQ, priv->base + IFI_CANFD_INTERRUPT); ^

How did this splat came to be ? I would expect that the expansion goes like
this:

const u32 clr_irq_mask = ~(IFI_CANFD_INTERRUPT_SET_IRQ |
                           IFI_CANFD_INTERRUPT_ERROR_WARNING);
const u32 clr_irq_mask = ~(BIT(31) | BIT(1));
const u32 clr_irq_mask = ~(0x80000002);
const u32 clr_irq_mask = 0x7ffffffd;

Did I miss something there ?

Thanks!

Best regards,
Marek Vasut