netdev - Re: [PATCH] connector: bump skb->users before callback invocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Jan 2016 23:03:22 +0300
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	David Miller <davem@...emloft.net>, "fw@...len.de" <fw@...len.de>
Cc:	"dvyukov@...gle.com" <dvyukov@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] connector: bump skb->users before callback invocation

Hi everyone

Thanks for fixing and quick pushing of this bug.

05.01.2016, 05:47, "David Miller" <davem@...emloft.net>:
> From: Florian Westphal <fw@...len.de>
> Date: Thu, 31 Dec 2015 14:26:33 +0100
>
>>  Dmitry reports memleak with syskaller program.
>>  Problem is that connector bumps skb usecount but might not invoke callback.
>>
>>  So move skb_get to where we invoke the callback.
>>
>>  Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
>>  Signed-off-by: Florian Westphal <fw@...len.de>
>
> Applied and queued up for -stable, thanks.