netdev - Re: [PATCH net] udp: disallow UFO for sockets with SO_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160111.174205.202764956086980022.davem@davemloft.net>
Date:	Mon, 11 Jan 2016 17:42:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	mkubecek@...e.cz
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	hannes@...essinduktion.org, shannon.nelson@...el.com,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net
Subject: Re: [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK
 option

From: Michal Kubecek <mkubecek@...e.cz>
Date: Mon, 11 Jan 2016 07:50:30 +0100 (CET)

> Commit acf8dd0a9d0b ("udp: only allow UFO for packets from SOCK_DGRAM
> sockets") disallows UFO for packets sent from raw sockets. We need to do
> the same also for SOCK_DGRAM sockets with SO_NO_CHECK options, even if
> for a bit different reason: while such socket would override the
> CHECKSUM_PARTIAL set by ip_ufo_append_data(), gso_size is still set and
> bad offloading flags warning is triggered in __skb_gso_segment().
> 
> In the IPv6 case, SO_NO_CHECK option is ignored but we need to disallow
> UFO for packets sent by sockets with UDP_NO_CHECK6_TX option.
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
> Tested-by: Shannon Nelson <shannon.nelson@...el.com>

Applied and queued up for -stable, thanks Michal.