netdev - Re: [PATCH net v2] bonding: Prevent IPv6 link local address on enslaved devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160111.175706.904376751900870814.davem@davemloft.net>
Date:	Mon, 11 Jan 2016 17:57:06 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	kheiss@...il.com
Cc:	netdev@...r.kernel.org, j.vosburgh@...il.com, vfalico@...il.com,
	gospo@...ulusnetworks.com
Subject: Re: [PATCH net v2] bonding: Prevent IPv6 link local address on
 enslaved devices

From: Karl Heiss <kheiss@...il.com>
Date: Mon, 11 Jan 2016 08:28:43 -0500

> Commit 1f718f0f4f97 ("bonding: populate neighbour's private on enslave")
> undoes the fix provided by commit c2edacf80e15 ("bonding / ipv6: no addrconf
> for slaves separately from master") by effectively setting the slave flag
> after the slave has been opened.  If the slave comes up quickly enough, it
> will go through the IPv6 addrconf before the slave flag has been set and
> will get a link local IPv6 address.
> 
> In order to ensure that addrconf knows to ignore the slave devices on state
> change, set IFF_SLAVE before dev_open() during bonding enslavement.
> 
> Fixes: 1f718f0f4f97 ("bonding: populate neighbour's private on enslave")
> 
> Signed-off-by: Karl Heiss <kheiss@...il.com>

Applied and queued up for -stable, thanks.