netdev - Re: [PATCH -next v2 1/2] net: tc35815: Fix build error due to missed API change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160110.233141.1537853356042839675.davem@davemloft.net>
Date:	Sun, 10 Jan 2016 23:31:41 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	linux@...ck-us.net
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	andrew@...n.ch
Subject: Re: [PATCH -next v2 1/2] net: tc35815: Fix build error due to
 missed API change

From: Guenter Roeck <linux@...ck-us.net>
Date: Sun, 10 Jan 2016 07:10:44 -0800

> Commit 7f854420fbfe ("phy: Add API for {un}registering an mdio device to
> a bus") introduces an API to access mii_bus structures, but missed to
> update the tc35815 driver. This results in the following error message.
> 
> drivers/net/ethernet/toshiba/tc35815.c: In function 'tc_mii_probe':
> drivers/net/ethernet/toshiba/tc35815.c:617:18: error:
> 	'struct mii_bus' has no member named 'phy_map'
> drivers/net/ethernet/toshiba/tc35815.c:623:24: error:
> 	'struct mii_bus' has no member named 'phy_map'
> 
> Instead of looping over the list of phy addresses to find a phy chip,
> use phy_find_first(). While the intent of the original code was to return
> an error if more than one phy was specified, this code path was never
> executed because the loop aborted after finding the first phy. The
> original code is therefore semantically identical to phy_find_first(),
> thus it is simpler and more straightforward to use phy_find_first()
> directly.
> 
> Fixes: 7f854420fbfe ("phy: Add API for {un}registering an mdio device to a bus")
> Cc: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied.