netdev - Re: [PATCH 1/3] ifb: make device count build-time configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452612711.18559.62.camel@v3.sk>
Date:	Tue, 12 Jan 2016 16:31:51 +0100
From:	Lubomir Rintel <lkundrak@...sk>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH 1/3] ifb: make device count build-time configurable

On Tue, 2016-01-12 at 16:19 +0100, Daniel Borkmann wrote:
> On 01/12/2016 12:56 PM, Lubomir Rintel wrote:
> > The devices can be created at run-time for quite some time already
> > and the
> > load-time device creation collides with attempts to create the
> > device of
> > the same name:
> > 
> >    # rmmod ifb
> >    # ip link add ifb0 type ifb
> >    RTNETLINK answers: File exists
> > 
> > This is pretty much the same situation as was with the block loop
> > devices
> > which was solved by adding a build-time configuration that the
> > distributions could use as they deem fit while keeping the default
> > for
> > compatibility.
> > 
> > Let's do that here as well.
> 
> Thanks for the set in general, good to see it fixed!
> 
> > Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> > ---
> [...]
> > +config IFB_COUNT
> > +        int "Number of ifb devices to pre-create at init time"
> > +        depends on IFB
> > +        default 3
> 
> Should that not be 2?

Yes, it should be. Good catch, thanks. Will follow-up with a fixed
patch.

Lubo