netdev - Re: [PATCH 1/3] ifb: make device count build-time configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452613429.18559.69.camel@v3.sk>
Date:	Tue, 12 Jan 2016 16:43:49 +0100
From:	Lubomir Rintel <lkundrak@...sk>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [PATCH 1/3] ifb: make device count build-time configurable

On Tue, 2016-01-12 at 16:35 +0100, Daniel Borkmann wrote:
> On 01/12/2016 04:19 PM, Daniel Borkmann wrote:
> > On 01/12/2016 12:56 PM, Lubomir Rintel wrote:
...
> > > -static int numifbs = 2;
> >                ^^^^^^^^^^^^
> > > +static int numifbs = CONFIG_IFB_COUNT;
> > >   module_param(numifbs, int, 0);
> > >   MODULE_PARM_DESC(numifbs, "Number of ifb devices");
> 
> Btw, perhaps there should also be a pr_info() or the like to warn the user
> that relying on modprobe creating these devs is deprecated and scheduled
> for removal in future, so they should switch to ip link instead ...

I don't know, is it actually is scheduled for removal?

I was under impression that changes in default behavior users can rely
on are generally near impossible to do since the potential problems
largely outweigh the benefits. The distributions will do the changes in
their kernels anyway and changing behavior on kernel upgrades in random
old systems might be risky.

That said, it's just an impression. I don't follow the development
closely enough to be sure about anything.

Lubo