netdev - Re: [PATCH] net: pktgen: fix null ptr deref in skb allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jan 2016 09:32:44 -0800
From:	John Fastabend <john.fastabend@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, bogdan.hamciuc@...escale.com
Subject: Re: [PATCH] net: pktgen: fix null ptr deref in skb allocation

On 16-01-11 02:40 PM, David Miller wrote:
> From: John Fastabend <john.fastabend@...il.com>
> Date: Sun, 10 Jan 2016 21:38:44 -0800
> 
>> Fix possible null pointer dereference that may occur when calling
>> skb_reserve() on a null skb.
>>
>> Fixes: 879c7220e82 ("net: pktgen: Observe needed_headroom of the device")
>> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> 
> I don't know how I missed that during review :-/

Well once you get pktgen running fast enough to get allocation
failures the occasional system halts are pretty hard to miss :)

> 
> Applied and queued up for -stable, thanks!
>