netdev - Re: [PATCH v3] netlink: fix null pointer dereference on nlk->groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160112.144049.336054136817784262.davem@davemloft.net>
Date:	Tue, 12 Jan 2016 14:40:49 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sploving1@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3] netlink: fix null pointer dereference on nlk->groups

From: Baozeng Ding <sploving1@...il.com>
Date: Tue, 12 Jan 2016 19:10:43 +0800

> If groups is not 0 and nlk->groups is NULL, it will not return
> immediately and cause a null pointer dereference later.
> 
> Signed-off-by: Baozeng Ding <sploving1@...il.com>
> ---
> The v3 version adds WARN_ON, suggested by David Miller. Thanks for
> David's feedback.

My feedback was also that the situation is illegal, and therefore you
have to explain to us how this can actually occur.