netdev - Re: [PATCH net] phonet: properly unshare skbs in phonet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160112.154718.762462936767801736.davem@davemloft.net>
Date:	Tue, 12 Jan 2016 15:47:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ivo.g.dimitrov.75@...il.com, courmisch@...il.com,
	noureddine@...sta.com, pali.rohar@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	sre@...nel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH net] phonet: properly unshare skbs in phonet_rcv()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 12 Jan 2016 08:58:00 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Ivaylo Dimitrov reported a regression caused by commit 7866a621043f
> ("dev: add per net_device packet type chains").
> 
> skb->dev becomes NULL and we crash in __netif_receive_skb_core().
> 
> Before above commit, different kind of bugs or corruptions could happen
> without major crash.
> 
> But the root cause is that phonet_rcv() can queue skb without checking
> if skb is shared or not.
> 
> Many thanks to Ivaylo Dimitrov for his help, diagnosis and tests.
> 
> Reported-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
> Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Remi Denis-Courmont <courmisch@...il.com>

Applied and queued up for -stable, th anks Eric.