netdev - Re: [PATCH 3/3] bonding: make device count build-time configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Jan 2016 22:40:35 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	David Miller <davem@...emloft.net>
Cc:	lkundrak@...sk, jay.vosburgh@...onical.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, vfalico@...il.com,
	gospo@...ulusnetworks.com
Subject: Re: [PATCH 3/3] bonding: make device count build-time configurable

David Miller <davem@...emloft.net> writes:
> From: Lubomir Rintel <lkundrak@...sk>
> Date: Tue, 12 Jan 2016 18:19:49 +0100
>
>> It's still an improvement to let the distributions decide if they're
>> keeping "ip link add" broken or possibly affecting the scripts.
>
> That it is "broken" is your opinion.
>
> Document the behavior.  It is not broken if the user is told to be
> mindful of what devices are created by default.
>
> There is way too much downside to changing this.

Besides, distributions or admins can already change that behaviour if
they consider it "broken", using the existing module parameter:

 # echo "options bonding max_bonds=0" >/etc/modprobe.d/bonding.conf
 # rmmod bonding
 # ip link add bond0 type bond
 (no error here)

This method should be well known and understood by most users, contrary
to some odd CONFIG_ build time setting.


Bjørn