netdev - Re: [ovs-dev] [PATCH] Openvswitch: datapath.c: Fixed coding style warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_C7h7UhOwZMiBzxPZO0p9g3dtGy5TmgFmDDg_eS7MuLNQ@mail.gmail.com>
Date:	Tue, 12 Jan 2016 14:19:20 -0800
From:	pravin shelar <pshelar@....org>
To:	Janusz Wolak <januszvdm@...kados.com.pl>
Cc:	Pravin Shelar <pshelar@...ira.com>, ovs dev <dev@...nvswitch.org>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [ovs-dev] [PATCH] Openvswitch: datapath.c: Fixed coding style warnings.

On Tue, Jan 12, 2016 at 1:55 PM, Janusz Wolak <januszvdm@...kados.com.pl> wrote:
> Removed: block comments trailing without separate line,
> missing blanks after decarations, comparasion to NULL, assignment in if
> condition, not necessary spaces after a casts, multiple assignments, line
> over 80 characters, alignment not matched to open parenthesis, kmalloc with
> multiplying instead kmalloc_array.
>
>
> Signed-off-by: Janusz Wolak <januszvdm@...kados.com.pl>
> ---
>  net/openvswitch/datapath.c | 75 ++++++++++++++++++++++++++--------------------
>  1 file changed, 42 insertions(+), 33 deletions(-)
>
> diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
> index 91a8b00..12ff8c2 100644
> --- a/net/openvswitch/datapath.c
> +++ b/net/openvswitch/datapath.c

...

> @@ -455,8 +457,8 @@ static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb,
>         }
>
>         /* Complete checksum if needed */
> -       if (skb->ip_summed == CHECKSUM_PARTIAL &&
> -           (err = skb_checksum_help(skb)))
> +       err = skb_checksum_help(skb);
> +       if (skb->ip_summed == CHECKSUM_PARTIAL && err)
>                 goto out;
>
skb checksum help can be expensive in some cases, so it should be
moved inside the if condition block.