netdev - Re: [PATCH net] ovs: add recursion limit to ovs_vport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56958F7B.4020806@stressinduktion.org>
Date:	Wed, 13 Jan 2016 00:42:51 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	netdev@...r.kernel.org
Cc:	dev@...nvswitch.org, Pravin Shelar <pshelar@....org>
Subject: Re: [PATCH net] ovs: add recursion limit to ovs_vport_receive

On 13.01.2016 00:39, Hannes Frederic Sowa wrote:
> +	if (__this_cpu_inc_return(ovs_recursion) > ovs_recursion_limit) {
> +		net_crit_ratelimited("ovs: recursion limit reached on datapath %s, probable configuration error\n",
> +				     ovs_dp_name(vport->dp));

Pravin, I assumed that it makes more sense to output the datapath name 
in the error message to link it to the configuration. Alternative would 
be vport name. What do you think?


> +		error = -ENETDOWN;
> +		kfree_skb(skb);
> +		goto out;
> +	}
> +