netdev - Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DA3FDF74-E3BD-474B-8C38-E21CAEEFE1DB@mellanox.com>
Date:	Wed, 13 Jan 2016 12:33:14 +0000
From:	Elad Raz <eladr@...lanox.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>,
	netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB


> On Jan 13, 2016, at 2:28 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> 
> There is a missing break statement so we always return -EOPNOTSUPP.
> 
> Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Acked-by: Elad Raz <eladr@...lanox.com>

> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> index ffe894e..45479ef 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> @@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
> 	case SWITCHDEV_OBJ_ID_PORT_MDB:
> 		err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
> 					    SWITCHDEV_OBJ_PORT_MDB(obj));
> +		break;
> 	default:
> 		err = -EOPNOTSUPP;
> 		break;