lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jan 2016 17:44:18 +0100 From: Andrew Lunn <andrew@...n.ch> To: shh.xie@...il.com Cc: devicetree@...r.kernel.org, netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, f.fainelli@...il.com, davem@...emloft.net, Shaohui Xie <Shaohui.Xie@...escale.com> Subject: Re: [PATCH 1/3][v2] net: phy: introduce 1000BASE-KX and 10GBASE-KR On Thu, Jan 14, 2016 at 04:23:59PM +0800, shh.xie@...il.com wrote: > From: Shaohui Xie <Shaohui.Xie@...escale.com> > > This commit adds necessary definitions for the PHY layer to recognize > backplane Ethernet 1000BASE-KX and 10GBASE-KR as valid PHY interfaces, > "1000base-kx" for 1000BASE-KX, "10gbase-kr" for 10GBASE-KR. > > Signed-off-by: Shaohui Xie <Shaohui.Xie@...escale.com> > --- > changes in v2: > new patch. > > Documentation/devicetree/bindings/net/ethernet.txt | 4 ++-- > include/linux/phy.h | 6 ++++++ > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/ethernet.txt b/Documentation/devicetree/bindings/net/ethernet.txt > index 5d88f37..1166a5c 100644 > --- a/Documentation/devicetree/bindings/net/ethernet.txt > +++ b/Documentation/devicetree/bindings/net/ethernet.txt > @@ -11,8 +11,8 @@ The following properties are common to the Ethernet controllers: > the maximum frame size (there's contradiction in ePAPR). > - phy-mode: string, operation mode of the PHY interface; supported values are > "mii", "gmii", "sgmii", "qsgmii", "tbi", "rev-mii", "rmii", "rgmii", "rgmii-id", > - "rgmii-rxid", "rgmii-txid", "rtbi", "smii", "xgmii"; this is now a de-facto > - standard property; > + "rgmii-rxid", "rgmii-txid", "rtbi", "smii", "xgmii", "1000base-kx", "10gbase-kr"; > + this is now a de-facto standard property; I know very little about this, so i'm just asking a question. None of the other interface modes contain a bit rate. So is the bit rate needed for your two new modes? With a bit of googling, K means copper backplane, X means 4B/5B and R means 64B/66B. Could there be a 10Gbps KX? a 1GBps KR? Do we actually need the speed here, or is kx and kr sufficient? Thanks Andrew
Powered by blists - more mailing lists