netdev - Re: [PATCH] net: phy: turn carrier off on phy attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1452802977.30596.46.camel@collabora.co.uk>
Date:	Thu, 14 Jan 2016 21:22:57 +0100
From:	Sjoerd Simons <sjoerd.simons@...labora.co.uk>
To:	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
	Andrew Lunn <andrew@...n.ch>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: turn carrier off on phy attach

On Tue, 2016-01-12 at 17:31 -0800, Florian Fainelli wrote:
> On January 9, 2016 10:44:05 AM PST, Sjoerd Simons <sjoerd.simons@...l
> abora.co.uk> wrote:
> > The operstate of a networking device initially IF_OPER_UNKNOWN aka
> > "unknown", updated on carrier state changes (with carrier state
> > being
> > on
> > by default). This means it will stay unknown unless the carrier
> > state
> > goes to off at some point, which is not the case if the phy is
> > already
> > up/connected at startup.
> 
> Correct, drivers typically call netif_carrier_off prior to
> registering the network device to give a predictable link state,
> regardless of whether or not they use PHYLIB.
> 
> > 
> > Explicitly turn off the carrier on phy attach, leaving the phy
> > state
> > machine to turn the carrier on when it has done the initial
> > negotiation.
> 
> Same comment as Andrew on the comment below.
> 
> Out of curiosity, was there a particular driver you ran into issues
> with?

Prepping a v2. This came up on Rada Rock2 board, so the (Rockchip)
DWMAC driver combined with a realtek phy (RTL8211E). Thanks for the
review

-- 
Sjoerd Simons
Collabora Ltd.