netdev - Re: [PATCH V3 1/6] net/ethtool: introduce a new ioctl for per queue setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1452996017.2519.29.camel@decadent.org.uk>
Date:	Sun, 17 Jan 2016 02:00:17 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	kan.liang@...el.com, netdev@...r.kernel.org, davem@...emloft.net,
	bwh@...nel.org
Cc:	jesse.brandeburg@...el.com, andi@...stfloor.org,
	f.fainelli@...il.com, alexander.duyck@...il.com,
	jeffrey.t.kirsher@...el.com, shannon.nelson@...el.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	mitch.a.williams@...el.com, ogerlitz@...lanox.com,
	edumazet@...gle.com, jiri@...lanox.com, sfeldma@...il.com,
	gospo@...ulusnetworks.com, sasha.levin@...cle.com,
	dsahern@...il.com, tj@...nel.org, cascardo@...hat.com,
	corbet@....net
Subject: Re: [PATCH V3 1/6] net/ethtool: introduce a new ioctl for per queue
 setting

On Thu, 2016-01-14 at 09:08 -0500, kan.liang@...el.com wrote:
[...]
> --- a/include/uapi/linux/ethtool.h
> +++ b/include/uapi/linux/ethtool.h
> @@ -1144,6 +1144,21 @@ enum ethtool_sfeatures_retval_bits {
>  #define ETHTOOL_F_WISH          (1 << ETHTOOL_F_WISH__BIT)
>  #define ETHTOOL_F_COMPAT        (1 << ETHTOOL_F_COMPAT__BIT)
>  
> +#define MAX_NUM_QUEUE		4096
> +
> +/**
> + * struct ethtool_per_queue_op - apply sub command to the queues in mask.
> + * @cmd: ETHTOOL_PERQUEUE
> + * @sub_command: the sub command which apply to each queues
> + * @queue_mask: Bitmap of the queues which sub command apply to
> + * @data: A complete command structure following for each of the queues addressed
> + */
> +struct ethtool_per_queue_op {
> +	__u32	cmd;
> +	__u32	sub_command;
> +	unsigned long queue_mask[BITS_TO_LONGS(MAX_NUM_QUEUE)];
[...]

I thought we already agreed that this won't work for 32-bit userland on
a big-endian 64-bit kernel?

Ben.

-- 
Ben Hutchings
Theory and practice are closer in theory than in practice.
                                - John Levine, moderator of comp.compilers
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)