netdev - Re: [PATCH 2/2] arm64: bpf: add extra pass to handle faulty codegen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160117.191545.670534349073994378.davem@davemloft.net>
Date:	Sun, 17 Jan 2016 19:15:45 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	zlim.lnx@...il.com
Cc:	ast@...nel.org, will.deacon@....com, catalin.marinas@....com,
	rabin@....in, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] arm64: bpf: add extra pass to handle faulty codegen

From: Zi Shen Lim <zlim.lnx@...il.com>
Date: Wed, 13 Jan 2016 23:33:22 -0800

> Code generation functions in arch/arm64/kernel/insn.c previously
> BUG_ON invalid parameters. Following change of that behavior, now we
> need to handle the error case where AARCH64_BREAK_FAULT is returned.
> 
> Instead of error-handling on every emit() in JIT, we add a new
> validation pass at the end of JIT compilation. There's no point in
> running JITed code at run-time only to trap due to AARCH64_BREAK_FAULT.
> Instead, we drop this failed JIT compilation and allow the system to
> gracefully fallback on the BPF interpreter.
> 
> Signed-off-by: Zi Shen Lim <zlim.lnx@...il.com>
> Suggested-by: Alexei Starovoitov <ast@...nel.org>

Applied.