netdev - Re: [PATCH net] team: Replace rcu_read_lock with a mutex in team_vlan_rx_kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160118.115538.1753600494506800913.davem@davemloft.net>
Date:	Mon, 18 Jan 2016 11:55:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	idosch@...lanox.com
Cc:	netdev@...r.kernel.org, jiri@...lanox.com, eladr@...lanox.com,
	yotamg@...lanox.com, ogerlitz@...lanox.com
Subject: Re: [PATCH net] team: Replace rcu_read_lock with a mutex in
 team_vlan_rx_kill_vid

From: Ido Schimmel <idosch@...lanox.com>
Date: Mon, 18 Jan 2016 17:30:22 +0200

> We can't be within an RCU read-side critical section when deleting
> VLANs, as underlying drivers might sleep during the hardware operation.
> Therefore, replace the RCU critical section with a mutex. This is
> consistent with team_vlan_rx_add_vid.
> 
> Fixes: 3d249d4ca7d0 ("net: introduce ethernet teaming device")
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied and queued up for -stable, thanks.