netdev - Re: [PATCH net v5] ovs: limit ovs recursions in ovs_execute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160118.121018.2292058052018055331.davem@davemloft.net>
Date:	Mon, 18 Jan 2016 12:10:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, pshelar@....org,
	simon.horman@...ronome.com, eric.dumazet@...il.com
Subject: Re: [PATCH net v5] ovs: limit ovs recursions in
 ovs_execute_actions to not corrupt stack

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Mon, 18 Jan 2016 18:03:48 +0100

> It was seen that defective configurations of openvswitch could overwrite
> the STACK_END_MAGIC and cause a hard crash of the kernel because of too
> many recursions within ovs.
> 
> This problem arises due to the high stack usage of openvswitch. The rest
> of the kernel is fine with the current limit of 10 (RECURSION_LIMIT).
> 
> We use the already existing recursion counter in ovs_execute_actions to
> implement an upper bound of 5 recursions.
> 
> Cc: Pravin Shelar <pshelar@....org>
> Cc: Simon Horman <simon.horman@...ronome.com>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Simon Horman <simon.horman@...ronome.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied, thanks Hannes.