netdev - Re: [PATCH V3 1/6] net/ethtool: introduce a new ioctl for per queue setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG88wWYosRjbdMXXuK2w7rvjmScf2ODaeyVXaaFK8NrLHhDFjA@mail.gmail.com>
Date:	Tue, 19 Jan 2016 11:30:21 -0800
From:	David Decotigny <decot@...glers.com>
To:	"Liang, Kan" <kan.liang@...el.com>
Cc:	Ben Hutchings <ben@...adent.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"bwh@...nel.org" <bwh@...nel.org>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"andi@...stfloor.org" <andi@...stfloor.org>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"alexander.duyck@...il.com" <alexander.duyck@...il.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Nelson, Shannon" <shannon.nelson@...el.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
	"Williams, Mitch A" <mitch.a.williams@...el.com>,
	"ogerlitz@...lanox.com" <ogerlitz@...lanox.com>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"jiri@...lanox.com" <jiri@...lanox.com>,
	"sfeldma@...il.com" <sfeldma@...il.com>,
	"gospo@...ulusnetworks.com" <gospo@...ulusnetworks.com>,
	"sasha.levin@...cle.com" <sasha.levin@...cle.com>,
	"dsahern@...il.com" <dsahern@...il.com>,
	"tj@...nel.org" <tj@...nel.org>,
	"cascardo@...hat.com" <cascardo@...hat.com>,
	"corbet@....net" <corbet@....net>
Subject: Re: [PATCH V3 1/6] net/ethtool: introduce a new ioctl for per queue setting

I have a v6 ready, didn't have a chance to test + send it for review.
will try to get done with it by tomorrow morning (PST).

On Sun, Jan 17, 2016 at 6:25 PM, Liang, Kan <kan.liang@...el.com> wrote:
>>
>> On Thu, 2016-01-14 at 09:08 -0500, kan.liang@...el.com wrote:
>> [...]
>> > --- a/include/uapi/linux/ethtool.h
>> > +++ b/include/uapi/linux/ethtool.h
>> > @@ -1144,6 +1144,21 @@ enum ethtool_sfeatures_retval_bits {
>> >  #define ETHTOOL_F_WISH          (1 << ETHTOOL_F_WISH__BIT)
>> >  #define ETHTOOL_F_COMPAT        (1 << ETHTOOL_F_COMPAT__BIT)
>> >
>> > +#define MAX_NUM_QUEUE              4096
>> > +
>> > +/**
>> > + * struct ethtool_per_queue_op - apply sub command to the queues in
>> mask.
>> > + * @cmd: ETHTOOL_PERQUEUE
>> > + * @sub_command: the sub command which apply to each queues
>> > + * @queue_mask: Bitmap of the queues which sub command apply to
>> > + * @data: A complete command structure following for each of the
>> > +queues addressed  */ struct ethtool_per_queue_op {
>> > +   __u32   cmd;
>> > +   __u32   sub_command;
>> > +   unsigned long
>> queue_mask[BITS_TO_LONGS(MAX_NUM_QUEUE)];
>> [...]
>>
>> I thought we already agreed that this won't work for 32-bit userland on a
>> big-endian 64-bit kernel?
>
> I found David Decotigny's patch. https://lkml.org/lkml/2015/12/14/728
> But it looks like it is not merged yet.
> Any idea when it will be merged to net-next or net?
> So I can build my patch on top of his patch.
>
> Thanks,
> Kan
>
>>
>> Ben.
>>
>> --
>> Ben Hutchings
>> Theory and practice are closer in theory than in practice.
>>                                 - John Levine, moderator of comp.compilers