lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Jan 2016 17:19:18 +0100 From: Bjørn Mork <bjorn@...k.no> To: Michael Grzeschik <m.grzeschik@...gutronix.de> Cc: mkl@...gutronix.de, wg@...ndegger.com, linux-can@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH v2] can: c_can: add xceiver enable/disable support Michael Grzeschik <m.grzeschik@...gutronix.de> writes: > @@ -1263,6 +1271,10 @@ int register_c_can_dev(struct net_device *dev) > */ > pinctrl_pm_select_sleep_state(dev->dev.parent); > > + priv->reg_xceiver = devm_regulator_get(priv->device, "xceiver"); > + if (IS_ERR(priv->reg_xceiver)) > + return PTR_ERR(priv->reg_xceiver); > + > c_can_pm_runtime_enable(priv); > > dev->flags |= IFF_ECHO; /* we support local echo */ Do you really want to leave priv->reg_xceiver pointing to an ERR_PTR in case of error? Bjørn
Powered by blists - more mailing lists