netdev - RE: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D40499B7D@CHN-SV-EXMX02.mchp-main.com>
Date:	Wed, 20 Jan 2016 22:20:04 +0000
From:	<Woojung.Huh@...rochip.com>
To:	<f.fainelli@...il.com>, <davem@...emloft.net>
CC:	<netdev@...r.kernel.org>, <andrew@...n.ch>,
	<sergei.shtylyov@...entembedded.com>
Subject: RE: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS

Florian & David,

I'm experiencing misbehavior after restart system.
Can you wait applying the patch?

Sorry about it.
Woojung

> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@...il.com]
> Sent: Wednesday, January 20, 2016 4:30 PM
> To: Woojung Huh - C21699; davem@...emloft.net
> Cc: netdev@...r.kernel.org; andrew@...n.ch;
> sergei.shtylyov@...entembedded.com
> Subject: Re: [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS
> 
> Le 20/01/2016 13:20, Woojung.Huh@...rochip.com a écrit :
> >>> Targetting the "net" tree since these are bugfixes, but I would like
> >>> Woojun and Andrew to take a look and test that on their respective
> >>> HW setups as well.
> >>
> >> Ok I'll wait for Woojun and Andrew to give feedback.
> >
> > This patch fixes periodic phy read_status access when phy is configured as
> PHY_IGNORE_INTERRUPTS.
> 
> Great, thanks for the feedback!
> 
> > Tested and confirmed with LAN78xx USB-to-Ethernet driver except
> following checkpatch.pl warnings.
> >
> > WARNING: line over 80 characters
> > #54: FILE: drivers/net/phy/phy.c:1008:
> > +		queue_delayed_work(system_power_efficient_wq,
> &phydev->state_queue,
> 
> This one is definitively added by the patch
> 
> >
> > WARNING: Comparisons should place the constant on the right side of the
> test
> > #68: FILE: drivers/net/phy/phy.c:714:
> > +		if (PHY_HALTED != phydev->state &&
> >
> 
> This one is an existing warning.
> 
> David, let me know if you consider the over 80 columns issue worth a
> resubmission or not, either way is fine with me.
> 
> Thanks!
> --
> Florian