netdev - Re: Kernel memory leak in bnx2x driver with vxlan tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1453249067.1223.300.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 19 Jan 2016 16:17:47 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jesse Gross <jesse@...nel.org>
Cc:	John <john.phillips5@....com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Tom Herbert <tom@...bertland.com>, david.roth@....com,
	Pravin B Shelar <pshelar@...ira.com>,
	Thomas Graf <tgraf@...g.ch>
Subject: Re: Kernel memory leak in bnx2x driver with vxlan tunnel

On Tue, 2016-01-19 at 16:00 -0800, Jesse Gross wrote:

> Oh, I wasn't disagreeing that there is a problem. I was just trying to
> point out the conceptual root of the problem rather than the
> individual instances in different tunnels implementations.
> 
> In any case, I think we can solve this by calling
> skb_release_head_state() in napi_skb_finish() and switching early
> demux to use skb_valid_dst().

Yes, but it will also have to call skb_dst_drop() or risk a leak of
prior one.

So what is the purpose of having a dst if we need to drop it ?

Adding code in GRO would be fine if someone explains me the purpose of
doing apparently useless work.

(refcounting on dst is not exactly free)