netdev - Re: [PATCH] sfc: Replace memset with eth_zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJX_Q+2OZf05CsXRm7LOU0anO54MuTKEx0reR_mve8QEBqwiPg@mail.gmail.com>
Date:	Wed, 20 Jan 2016 09:49:02 -0200
From:	Lucas Tanure <tanure@...ux.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Shradha Shah <sshah@...arflare.com>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sfc: Replace memset with eth_zero_addr

Hi,

On Wed, Jan 20, 2016 at 9:44 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
> On 1/20/2016 2:27 AM, Lucas Tanure wrote:
>
>> Use eth_zero_addr to assign the zero address to the given address array
>> instead of memset when second argument is address of zero.
>
>
>    What address? memset() takes just 1 address. :-)

I mean the vf->mac, a pointer to a six-byte array containing the
Ethernet address.

>
>> Signed-off-by: Lucas Tanure <tanure@...ux.com>
>> ---
>>   drivers/net/ethernet/sfc/ef10_sriov.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c
>> b/drivers/net/ethernet/sfc/ef10_sriov.c
>> index 3c17f27..10f60db 100644
>> --- a/drivers/net/ethernet/sfc/ef10_sriov.c
>> +++ b/drivers/net/ethernet/sfc/ef10_sriov.c
>> @@ -527,7 +527,7 @@ int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int
>> vf_i, u8 *mac)
>>         return 0;
>>
>>   fail:
>> -       memset(vf->mac, 0, ETH_ALEN);
>> +       eth_zero_addr(vf->mac);
>>         return rc;
>>   }
>>
>
> MBR, Sergei
>

Thanks, Tanure