netdev - Re: [PATCH] net: dp83640: Fix tx timestamp overflow handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160120132545.GB2032@netboy>
Date:	Wed, 20 Jan 2016 14:25:45 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Manfred Rudigier <manfred.rudigier@...cron.at>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: dp83640: Fix tx timestamp overflow handling.

On Wed, Jan 20, 2016 at 11:22:28AM +0100, Manfred Rudigier wrote:
> PHY status frames are not reliable, the PHY may not be able to send them
> during heavy receive traffic. This overflow condition is signaled by the
> PHY in the next status frame, but the driver did not make use of it.
> Instead it always reported wrong tx timestamps to user space after an
> overflow happened because it assigned newly received tx timestamps to old
> packets in the queue.
> 
> This commit fixes this issue by clearing the tx timestamp queue every time
> an overflow happens, so that no timestamps are delivered for overflow
> packets. This way time stamping will continue correctly after an overflow.

Hi Manfred,

Thanks for finding and fixing this bug.

Dave, this patch should also go into stable.

Acked-by: Richard Cochran <richardcochran@...il.com>