netdev - Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160120.185009.540864680237250881.davem@davemloft.net>
Date:	Wed, 20 Jan 2016 18:50:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jesse@...nel.org
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com, tgraf@...g.ch,
	john.phillips5@....com
Subject: Re: [PATCH net v2] gro: Make GRO aware of lightweight tunnels.

From: Jesse Gross <jesse@...nel.org>
Date: Wed, 20 Jan 2016 17:59:49 -0800

> GRO is currently not aware of tunnel metadata generated by lightweight
> tunnels and stored in the dst. This leads to two possible problems:
>  * Incorrectly merging two frames that have different metadata.
>  * Leaking of allocated metadata from merged frames.
> 
> This avoids those problems by comparing the tunnel information before
> merging, similar to how we handle other metadata (such as vlan tags),
> and releasing any state when we are done.
> 
> Reported-by: John <john.phillips5@....com>
> Fixes: 2e15ea39 ("ip_gre: Add support to collect tunnel metadata.")
> Signed-off-by: Jesse Gross <jesse@...nel.org>
> ---
> v2: Remove branches to optimize for common case where there is no dst.

Applied and queued up for -stable, thanks.