netdev - Re: [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1453347139.3312.2.camel@intel.com>
Date:	Wed, 20 Jan 2016 19:32:19 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Pavel Tikhomirov <ptikhomirov@...tuozzo.com>,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Cc:	Andrew Vagin <avagin@...allels.com>,
	Konstantin Khorenko <khorenko@...tuozzo.com>, devel@...nvz.org
Subject: Re: [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields

On Wed, 2016-01-20 at 11:08 +0300, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to
> address
> multiple issues")
> 
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
> 
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
> 
> v2: follow commit citing style
> 
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@...tuozzo.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Why are you re-sending this patch?  I already have it queued up for
testing in my tree.  This just causes problems and extra work for me.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)