netdev - Re: [PATCH net] tcp: fix NULL deref in tcp_v4_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQyk+8G6bkhh5g_JxqpeeCquMrVfwA9=otMfmhFSYtVZAjg@mail.gmail.com>
Date:	Thu, 21 Jan 2016 11:06:02 -0500
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Jerry Chu <hkchu@...gle.com>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net] tcp: fix NULL deref in tcp_v4_send_ack()

On Thu, Jan 21, 2016 at 11:02 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
...
> The problem here is the skb we provide to tcp_v4_send_ack() had to
> be parked in the backlog of a new TCP fastopen child because this child
> was owned by the user at the time an out of window packet arrived.
>
> Before queuing a packet, TCP has to set skb->dev to NULL as the device
> could disappear before packet is removed from the queue.
>
> Fix this issue by using the net pointer provided by the socket (being a
> timewait or a request socket).

Thanks, Eric!

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal