netdev - Re: [PATCH 3/3] net: wireless: rt2x00: Space Required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 Jan 2016 18:10:30 +0100
From:	Helmut Schaa <helmut.schaa@...glemail.com>
To:	Paul McQuade <paulmcquad@...il.com>
Cc:	Stanislaw Gruszka <sgruszka@...hat.com>, kvalo@...eaurora.org,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] net: wireless: rt2x00: Space Required

On Sat, Oct 17, 2015 at 11:11 PM, Paul McQuade <paulmcquad@...il.com> wrote:
> Space needed before open parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad@...il.com>

Looks valid to me.

Acked-by: Helmut Schaa <helmut.schaa@...glemail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00debug.c b/drivers/net/wireless/rt2x00/rt2x00debug.c
> index 90fdb02..25ee3cb 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00debug.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00debug.c
> @@ -629,7 +629,7 @@ static struct dentry *rt2x00debug_create_file_chipset(const char *name,
>         data += sprintf(data, "register\tbase\twords\twordsize\n");
>  #define RT2X00DEBUGFS_SPRINTF_REGISTER(__name)                 \
>  {                                                              \
> -       if(debug->__name.read)                                  \
> +       if (debug->__name.read)                                 \
>                 data += sprintf(data, __stringify(__name)       \
>                                 "\t%d\t%d\t%d\n",               \
>                                 debug->__name.word_base,        \
> @@ -699,7 +699,7 @@ void rt2x00debug_register(struct rt2x00_dev *rt2x00dev)
>
>  #define RT2X00DEBUGFS_CREATE_REGISTER_ENTRY(__intf, __name)                    \
>  ({                                                                             \
> -       if(debug->__name.read) {                                                \
> +       if (debug->__name.read) {                                               \
>                 (__intf)->__name##_off_entry =                                  \
>                 debugfs_create_u32(__stringify(__name) "_offset",               \
>                                        S_IRUSR | S_IWUSR,                       \
> --
> 2.6.1
>