netdev - Re: net: GPF in netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56A3DCF7.7000404@iogearbox.net>
Date:	Sat, 23 Jan 2016 21:05:11 +0100
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Florian Westphal <fw@...len.de>, Dmitry Vyukov <dvyukov@...gle.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Thomas Graf <tgraf@...g.ch>,
	Ken-ichirou MATSUZAWA <chamaken@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	David Herrmann <dh.herrmann@...il.com>,
	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	syzkaller <syzkaller@...glegroups.com>,
	Kostya Serebryany <kcc@...gle.com>,
	Alexander Potapenko <glider@...gle.com>,
	Sasha Levin <sasha.levin@...cle.com>,
	netfilter-devel@...r.kernel.org
Subject: Re: net: GPF in netlink_getsockbyportid

On 01/23/2016 08:25 PM, Florian Westphal wrote:
> Dmitry Vyukov <dvyukov@...gle.com> wrote:
>
> [ CC nf-devel, not sure if its nfnetlink fault or NETLINK_MMAP ]
>
>> The following program causes GPF in netlink_getsockbyportid:
>>
>> // autogenerated by syzkaller (http://github.com/google/syzkaller)
>> #include <pthread.h>
>> #include <stdint.h>
>> #include <string.h>
>> #include <sys/syscall.h>
>> #include <unistd.h>
>>
>> int main()
>> {
>>    syscall(SYS_mmap, 0x20000000ul, 0xe65000ul, 0x3ul, 0x32ul,
>>                   0xfffffffffffffffful, 0x0ul);
>>    int fd = syscall(SYS_socket, 0x10ul, 0x803ul, 0xcul, 0, 0, 0);
>>    *(uint32_t*)0x20e64000 = (uint32_t)0x28;
>>    *(uint32_t*)0x20e64004 = (uint32_t)0x10;
>>    *(uint64_t*)0x20e64008 = (uint64_t)0x0;
>>    *(uint64_t*)0x20e64010 = (uint64_t)0x3;
>>    *(uint64_t*)0x20e64018 = (uint64_t)0xfff;
>>    *(uint16_t*)0x20e64020 = (uint16_t)0x5;
>>    syscall(SYS_write, fd, 0x20e64000ul, 0x28ul, 0, 0, 0);
>>    return 0;
>> }
>
> CONFIG_NETLINK_MMAP and nfnetlink batching strike in unison :-/
>
> root cause is in nfnetlink_rcv_batch():
>
> 296 replay:
> 297         status = 0;
> 298
> 299         skb = netlink_skb_clone(oskb, GFP_KERNEL);
>
> The clone op doesn't copy oskb->sk, so we oops in
> __netlink_alloc_skb -> netlink_getsockbyportid() when nfnetlink_rcv_batch
> tries to send netlink ack.

If indeed oskb is the mmap'ed netlink skb, then it's not even allowed
to call into skb_clone() as it would access skb shared info data that
can be controlled by the user space mmap buffer, iirc, we had that in
the past with nlmon where skb_clone() was accidentally used.